-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flash fallback throws error in IE8 when Flash is not available #631
Comments
There are now new bugs regarding this issue. One I've mentioned here: #865 (comment)
And after adding a conditional check around this code block, another one pops up here once you hit the play button:
Even though it's embedded in a try/catch statement, IE8 without Flash still throws an error that 'this.tech is null or not an object'. I think the optimal solution would be to integrate a check for the Flash fallback into VideoJS, if the video tag isn't available. |
Working through this in #1041 |
While using IE8 when Flash is not available, video.js throws an uncaught JavaScript error. The error is at line 450 of player.js, on a check for this.tech.isReady_. this.tech is undefined in this situation so this fails with the error "this.tech.isReady_ is null or not an object" as given by IE8. I have not tested this in other non-HTML5 browsers.
Steps to reproduce:
Expected behavior: video.js should gracefully handle this without throwing an error.
To fix this we must check that this.tech is defined before checking this.tech.isReady_. Curiously there is commented-out code directly above this line that does just that.
The text was updated successfully, but these errors were encountered: