Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug in MSIE8 where HTML5 and Flash are not available #1041

Closed
wants to merge 1 commit into from

Conversation

sugendran
Copy link

the active user checker was throwing errors because there was no tech available for playback

the active user checker was throwing errors because there was no tech available for playback
@heff
Copy link
Member

heff commented Feb 28, 2014

Thanks for this! I think this would be better fixed by adding the check for tech here, where the tech actually referenced:
https://github.com/sugendran/video.js/blob/IE8BugFix/src/js/player.js#L1278

Would you mind updating it and testing if that works?

@heff heff added bug labels Feb 28, 2014
@sugendran
Copy link
Author

Can look at that later today/tomorrow.

Should the inactive classes still get applied if there is no tech to play? At that point we'd just see the not supported message. So is there any reason to add more events to the DOM to find out if the user is active or not?

@heff
Copy link
Member

heff commented Mar 4, 2014

Well there's a small issue where if we were some how able to recover from the error, e.g. setting a new source, the userActive listeners would no longer work in that case as is. With that in mind, I don't see any specific problem with still adding the class, but if you see something let me know.

@heff
Copy link
Member

heff commented Mar 4, 2014

Also #631 has a comment that says there's a new error after fixing this one. Do you see the same?

@heff
Copy link
Member

heff commented Mar 26, 2014

@heff heff closed this Mar 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug confirmed needs: more info Please make enough detailed information is added to be actionable.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants