-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all dependencies need to be explicit for yarn 2 #7109
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
I don't understand why yarn would be resolving vhs-utils to 3.x with that version of Video.js. VHS is setting a 2.x version and m3u8-parser and mpd-parser and aes-decrypter also point at 2.x. However, yes, we probably need to better support yarn 2. |
Ok, maybe it isn't yarn 2 that's at fault for vhs-utils 3 based on convo in #6909. |
Because VHS is inlined into Video.js, we should depend on what VHS depends on. Fixes videojs#7091, fixes videojs#7209, fixes videojs#7144, fixes videojs#7109
Description
When using yarn 2, the build fails with a number errors like the following:
I believe the reason for that is that some dependencies are not explicit and come transitively from
@videojs/http-streaming
.The workaround is to add those dependencies to the
.yarnrc.yml
:What makes it more cumbersome is that we need to pin down those versions (otherwise yarn will resolve vhs-utils v3 which is not compatible with video.js 7.11.5).
The solution for this would be listing these dependencies explicitly in
package.json
.Additional Information
versions
videojs
7.11.5
The text was updated successfully, but these errors were encountered: