-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In video.js, when the source content type is "audio/mp3", the subtitle of the track is not updated. #7910
Comments
👋 Thanks for opening your first issue here! 👋 If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. |
After updating from 7.9.7 to 7.20.2, I also experience this problem of subtitle not updating on Samsung TV (Tizen OS). When I switched subtitle for a video with multiple subtitles, the current cue would show (if there was an active one) and it just stayed there forever, switching to another subtitle and the same thing happened. I think it has something to do with the 'cuechange' event. My content is H264 video with AAC LC 6 channel audio, so I don't think the content type matters. |
It's to do with using The video on Samsung doesn't really make sense, but TVs do do strange things. I think we'll just have to use |
Use the timeupdate event as well as the rvfc and raf callbacks to check cues. This is a bit overkill for "usual" playback but avoids edge cases. If the more preceise callback trigger first the cue will update but the timeupdate event should catch any that were missed, notwithstanding that timeupdate was always somewhat unpredictable. Fixes #7910 (audio in video els and Samsung being weird) and fixes #7902 (no updates off screen).
Problem solved :) |
I can confirm subtitle now works again on Samsung TV, and Sony TV too. |
Hello |
Use the timeupdate event as well as the rvfc and raf callbacks to check cues. This is a bit overkill for "usual" playback but avoids edge cases. If the more preceise callback trigger first the cue will update but the timeupdate event should catch any that were missed, notwithstanding that timeupdate was always somewhat unpredictable. Fixes #7910 (audio in video els and Samsung being weird) and fixes #7902 (no updates off screen).
Use the timeupdate event as well as the rvfc and raf callbacks to check cues. This is a bit overkill for "usual" playback but avoids edge cases. If the more preceise callback trigger first the cue will update but the timeupdate event should catch any that were missed, notwithstanding that timeupdate was always somewhat unpredictable. Fixes videojs#7910 (audio in video els and Samsung being weird) and fixes videojs#7902 (no updates off screen).
Description
I am trying to add subtitles to audio.
In video.js, when the source content type is "audio/mp3", the subtitle of the track is not updated.
We have prepared a Demo page.
Demo page.
https://iranika.github.io/videojs-debug/
Souce Code.
https://github.com/iranika/videojs-debug
What is interesting is that when you change the caption or operate the fullscrean, the subtitle will be displayed.
However, the subtitle is not updated.
In Chrome. ( Firefox is not occurred.)
It's not detecting the cuechange Event, i think well...
Is this a bug?
Reduced test case
https://github.com/iranika/videojs-debug
Steps to reproduce
Demo page.
https://iranika.github.io/videojs-debug/
Souce Code.
https://github.com/iranika/videojs-debug
Errors
No response
What version of Video.js are you using?
latest 7.10.2
Video.js plugins used.
No response
What browser(s) including version(s) does this occur with?
Chrome 105.0.5195.53
What OS(es) and version(s) does this occur with?
Windows11
The text was updated successfully, but these errors were encountered: