Add network and ready state properties #1854
Conversation
Expose the network state property on the Flash and HTML techs. Stub the method out for the mediafaker. Verify the method is exported with minification.
Expose a ready state method on the player object. Add tests to verify its presence.
|
lgtm! Do we want to add anything on the Flash side to handle readyState? I think it will error otherwise. We could potentially build a shim into MediaTechController that listens for the element events and adjusts an internal readyState, so we don't necessarily have to built it into the swf. e.g. the loadedmetadata event would switch the tech ready state to have_metadata. |
|
@heff believe it or not, readyState is already defined on the SWF. I was surprised, too. |
|
wuuuuuuttt??? Wow, that's great. On Wed, Feb 11, 2015 at 8:20 AM, David LaPalomento <notifications@github.com
|
The network and ready state properties of the video element expose important information about playback and buffering that cannot be obtained otherwise. For the HTML5 tech, the player can simply pass through the respective properties. The Flash tech has some level of support for both states, though it's probably simplistic. Even if the Flash implementation isn't perfect, having access to the properties without having to dig through the player internals is worth it.