Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove IE-specific code #7701

Merged
merged 1 commit into from
May 16, 2022

Conversation

alex-barstow
Copy link
Contributor

Description

Remove any IE-specific code, which is no longer needed once #7482 is merged to drop build support for IE.

@alex-barstow alex-barstow changed the base branch from main to next April 4, 2022 20:43
@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #7701 (23b9182) into next (f20aa9a) will increase coverage by 0.16%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             next    #7701      +/-   ##
==========================================
+ Coverage   80.88%   81.05%   +0.16%     
==========================================
  Files         116      116              
  Lines        7454     7436      -18     
  Branches     1806     1795      -11     
==========================================
- Hits         6029     6027       -2     
+ Misses       1425     1409      -16     
Impacted Files Coverage Δ
src/js/big-play-button.js 27.58% <0.00%> (+3.34%) ⬆️
src/js/live-tracker.js 98.42% <ø> (+4.99%) ⬆️
src/js/poster-image.js 74.19% <0.00%> (+8.47%) ⬆️
src/js/player.js 88.37% <100.00%> (ø)
src/js/tracks/text-track.js 92.94% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f20aa9a...23b9182. Read the comment docs.

@alex-barstow alex-barstow marked this pull request as ready for review April 6, 2022 19:31
@misteroneill misteroneill merged commit d34eb2b into videojs:next May 16, 2022
misteroneill pushed a commit that referenced this pull request May 19, 2022
BREAKING CHANGE: This will cause Video.js to fail in many cases in all versions of Internet Explorer.
misteroneill pushed a commit that referenced this pull request May 23, 2022
BREAKING CHANGE: This will cause Video.js to fail in many cases in all versions of Internet Explorer.
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
BREAKING CHANGE: This will cause Video.js to fail in many cases in all versions of Internet Explorer.
misteroneill pushed a commit that referenced this pull request Nov 23, 2022
BREAKING CHANGE: This will cause Video.js to fail in many cases in all versions of Internet Explorer.
amtins added a commit to amtins/video.js that referenced this pull request May 29, 2023
- remove IE-specific code, refer to videojs#7701 & videojs#7708
- remove remaining code to hide labels, refer to videojs#8101
edirub pushed a commit to edirub/video.js that referenced this pull request Jun 8, 2023
BREAKING CHANGE: This will cause Video.js to fail in many cases in all versions of Internet Explorer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants