-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: generate Typescript definitions #7954
Conversation
Codecov Report
@@ Coverage Diff @@
## next #7954 +/- ##
==========================================
+ Coverage 81.96% 81.97% +0.01%
==========================================
Files 111 110 -1
Lines 7356 7329 -27
Branches 1776 1767 -9
==========================================
- Hits 6029 6008 -21
+ Misses 1327 1321 -6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is cool and would be nice to have up-to-date types.
@gkatsev Should I add some additional changes for docs (guides, readme)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think any of the existing jsdocs need updating unless you wanted to do so. Can also be a separate effort/done on a case-by-case basis.
Description
Generate Typescript definitions based on JSDoc comments.
TODO:
Specific Changes proposed
Improves player config to handle the generating of Typescript definitions during the build process.
Requirements Checklist