Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fullscreen styles for older Safari #8346

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

mister-ben
Copy link
Contributor

Description

Works around and issue with older Safari versions (=<15.6) with sizing the player fullscreen with inline-block.

Fixes #8339

Specific Changes proposed

Sets display: block in fullscreen.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Merging #8346 (a2493a7) into main (146008f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8346   +/-   ##
=======================================
  Coverage   82.68%   82.68%           
=======================================
  Files         113      113           
  Lines        7562     7562           
  Branches     1818     1818           
=======================================
  Hits         6253     6253           
  Misses       1309     1309           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mister-ben mister-ben merged commit c11d213 into videojs:main Jul 6, 2023
@mister-ben mister-ben deleted the safari-fullscreen branch July 6, 2023 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Safari: fullscreen button is not working
2 participants