fix(player): adapt player height to control bar height in audioOnly mode #8579
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adapts the
player.height
to thecontrolBar.currentHeight
when theaudioOnlyMode
isenabled
. This ensures that the player height and control bar height are always in sync when the player is resized.This issue occurs when the
responsive
, andaudioOnlyMode
options are set totrue
, and the base font size adapts based on the player’s size to create a more responsive user interface.Screencast.from.27.01.24.13.28.25.webm
How to reproduce
Specific Changes proposed
updatePlayerHeightOnAudioOnlyMode_
function that will update the player height according to the control bar height when the player is resizedenableAudioOnlyUI_
controlBarHeight
toaudioOnlyCache_
to keep track of the control bar height changes when the player is resizedplayerresize
listenerdisableAudioOnlyUI_
to remove theplayerresize
listenerRequirements Checklist