Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure aria-labelledby values in track settings are valid #8711

Merged
merged 1 commit into from
May 6, 2024

Conversation

mister-ben
Copy link
Contributor

Description

Fixes new text track settings, so that aria-labelledby attributes contain only valid attributes. Currently there is one invalid id, and two els with duplicate ids.
Fixes #8708

Specific Changes proposed

Updates text-track-settings.js to set the id property to an empty string where there is no label, only a legend element.
Adds tests to validate aria-labelled by values.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
  • Reviewed by Two Core Contributors

Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.00%. Comparing base (466fa97) to head (d627211).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8711   +/-   ##
=======================================
  Coverage   83.00%   83.00%           
=======================================
  Files         120      120           
  Lines        7996     7996           
  Branches     1926     1926           
=======================================
  Hits         6637     6637           
  Misses       1359     1359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adrums86 adrums86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. :shipit:

@adrums86 adrums86 merged commit ad3be35 into videojs:main May 6, 2024
11 checks passed
@mister-ben mister-ben deleted the text-track-settings branch May 6, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[8.13.0] HTML-validation errors with the new version
2 participants