Clean up code #4
Conversation
| uint8_t row = number / 8; | ||
| uint8_t mask = 1U << number % 8; | ||
| for (int8_t column = MAX_LAYER_BITS - 1; column >= 0; --column) { | ||
| mask_byte(&layers_cache[row][column], layer & _BV(column), mask); |
There was a problem hiding this comment.
_BV seems to be defined in avr/io.h which is not included currently.
There was a problem hiding this comment.
The code compiles for me. It seems that it's included in pgmspace.h, which is itself included in action_macro.h, which is itself included in action_layer.c.
There was a problem hiding this comment.
It builds but I get a warning about an implicit function declaration from RTags. I'd rather stay on the safe side and include this header explicitly.
I still haven't tested if it works.
|
Ok, I've tested it. Seems to be working. Apart from these two comments above, the code look good to me. Nonetheless it's a mostly opinion based change so let's see what the upstream will say. Submit it to Jack's repo and let's see. Can I close this PR or do you want me to merge it to my fork anyway? |
|
I'll send a PR to the main repo. |
|
Sorry, sleep etc. ;) Regarding the inline functions: In this case it definitely won't hurt though the compiler might inline them anyway. Or might not anyway. |
|
It's jackhumbert#321. |
Added diagonal mice macros, breathing ala Atomic
The code should be significantly easier to understand now.