Ch/qa scrolling #458
Merged
Ch/qa scrolling #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccchwang
commented
Dec 22, 2017
| @@ -4,6 +4,7 @@ import Link from 'gatsby-link' | |||
| import Helmet from 'react-helmet' | |||
| import VigetLogo from '../components/viget-logo' | |||
|
|
|||
| import 'intersection-observer' | |||
ccchwang
commented
Dec 22, 2017
| @@ -35,7 +49,9 @@ export default class IndexPage extends React.Component { | |||
| ) | |||
|
|
|||
| //start observing each graphic | |||
| this.graphics.forEach(graphic => observer.observe(graphic)) | |||
| for (let i = 0; i < this.graphics.length; i++) { | |||
There was a problem hiding this comment.
changed this to a for loop because it wasn't working in IE
leobauza
approved these changes
Jan 2, 2018
Codecov Report
@@ Coverage Diff @@
## ch/layout #458 +/- ##
==========================================
Coverage 76.51% 76.51%
==========================================
Files 44 44
Lines 1367 1367
Branches 253 253
==========================================
Hits 1046 1046
Misses 263 263
Partials 58 58Continue to review full report at Codecov.
|
ccchwang
pushed a commit
that referenced
this pull request
Jan 3, 2018
* starting styling layout and structure of mobile * added styling for desktop layout * tweaked heading margin * ran yarn format * ran yarn format * removed prettier dev dependency * Ch/qa scrolling (#458)
ccchwang
pushed a commit
that referenced
this pull request
Jan 3, 2018
* started implementing functionality to change bg color * refactored footer for changing bg color, refactored scss to be more modular * rebased branch, refactored to take advantage of rerender * refactored color changing functionality so that nav and footer can change color as well * ran yarn format * removed prettier as dev dependency to use root rules instead * Ch/layout (#457) * Ch/qa scrolling (#458)
ccchwang
pushed a commit
that referenced
this pull request
Jan 3, 2018
* started implementing functionality to change bg color * refactored footer for changing bg color, refactored scss to be more modular * rebased branch, refactored to take advantage of rerender * refactored color changing functionality so that nav and footer can change color as well * ran yarn format * removed prettier as dev dependency to use root rules instead * Ch/layout (#457) * Ch/qa scrolling (#458)
ccchwang
pushed a commit
that referenced
this pull request
Jan 3, 2018
* trial 1 for locked scroll behavior * trying out two columns layout * experimenting with react-intersection-observer * set up IntersectionObserver and have it pull from json file * restructured base layout for new design and did basic styling * implementing intersection observer to change text on scroll * added functionality to change view by button and started refactoring * tweaked Intersection Observer to run smoother, added third section * removed unnecessary comments * remove comment * ran yarn format * fixed weird formatting by yarn * fixed more weird formatting by yarn * tweaking based on PR comments * finished refactoring to change classnames on rerender * refactored to rerender based on one state property only * changed var name to be more clear * got rid of unnecessary ids * ran yarn format * removed prettier as dev dependency and ran yarn format * Ch/bg color change (#456) * Ch/layout (#457) * Ch/qa scrolling (#458) * moved polyfill inside componentDidMount * trying new way to import polyfill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some initial QA on layout and scroll behavior. It:
position: stickyon IE