-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lazy load images #469
lazy load images #469
Conversation
@@ -7,7 +7,6 @@ const BrowserIcon = () => ( | |||
height="24" | |||
viewBox="0 0 24 24" | |||
style={{ marginRight: '10px' }} | |||
preserveAspectRatio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
got rid of this because it was causing console errors and also not needed
@nhunzaker |
Bummer. Looks like it might be a caching issue. I think the build caches based on the root package.json. This site is separate, so it might have gotten stuck. I clicked "rebuild without cache". Let's see what happens. I'll also make a note to look at why this happened. |
Ahhh. I see now. |
Codecov Report
@@ Coverage Diff @@
## master #469 +/- ##
==========================================
- Coverage 97.18% 95.83% -1.36%
==========================================
Files 31 29 -2
Lines 1103 1033 -70
Branches 204 195 -9
==========================================
- Hits 1072 990 -82
- Misses 27 37 +10
- Partials 4 6 +2
Continue to review full report at Codecov.
|
@nhunzaker couldn't figure out why yarn was not installing that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 one q on indentation of the scss
|
||
.lazyloaded { | ||
opacity: 1; | ||
transition: opacity 0.3s; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these over indented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't look like it in my code, not sure why it's doing that....
Added this lazysizes plugin and set some load styles.