Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy load images #469

Merged
merged 5 commits into from
Jan 11, 2018
Merged

lazy load images #469

merged 5 commits into from
Jan 11, 2018

Conversation

ccchwang
Copy link

@ccchwang ccchwang commented Jan 9, 2018

Added this lazysizes plugin and set some load styles.

@@ -7,7 +7,6 @@ const BrowserIcon = () => (
height="24"
viewBox="0 0 24 24"
style={{ marginRight: '10px' }}
preserveAspectRatio
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got rid of this because it was causing console errors and also not needed

@ccchwang
Copy link
Author

ccchwang commented Jan 9, 2018

@nhunzaker yarn deploy seems to work, but now it's failing because it can't find the react-lazysizes library I installed. I do see it in my node_modules so not sure why it can't find?

@nhunzaker
Copy link
Contributor

Bummer. Looks like it might be a caching issue. I think the build caches based on the root package.json. This site is separate, so it might have gotten stuck.

I clicked "rebuild without cache". Let's see what happens. I'll also make a note to look at why this happened.

@nhunzaker
Copy link
Contributor

Ahhh. I see now. react-lazysizes depends on lazysizes, which isn't getting pulled in for some reason. Hmmm.

@codecov-io
Copy link

codecov-io commented Jan 10, 2018

Codecov Report

Merging #469 into master will decrease coverage by 1.35%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #469      +/-   ##
==========================================
- Coverage   97.18%   95.83%   -1.36%     
==========================================
  Files          31       29       -2     
  Lines        1103     1033      -70     
  Branches      204      195       -9     
==========================================
- Hits         1072      990      -82     
- Misses         27       37      +10     
- Partials        4        6       +2
Impacted Files Coverage Δ
packages/microcosm/src/history.js 87.12% <0%> (-7.58%) ⬇️
packages/microcosm/src/key-path.js 78.57% <0%> (-7.15%) ⬇️
packages/microcosm/src/domain-engine.js 97.05% <0%> (-2.95%) ⬇️
packages/microcosm/src/action.js 97.43% <0%> (-2.57%) ⬇️
packages/microcosm/src/microcosm.js 99.05% <0%> (ø) ⬆️
packages/microcosm/src/addons/indexing.js
packages/microcosm/src/addons/action-button.js
packages/microcosm/src/utils.js 98.63% <0%> (+1.36%) ⬆️
packages/microcosm/src/effect-engine.js 100% <0%> (+5.55%) ⬆️
packages/microcosm/src/addons/action-queue.js 100% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71f0bc6...1fbf86a. Read the comment docs.

@ccchwang ccchwang requested a review from leobauza January 10, 2018 21:40
@ccchwang
Copy link
Author

ccchwang commented Jan 10, 2018

@nhunzaker couldn't figure out why yarn was not installing that lazysizes dependency 😣 it wasn't a well-maintained package anyways so I used something else

Copy link
Contributor

@leobauza leobauza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 one q on indentation of the scss


.lazyloaded {
opacity: 1;
transition: opacity 0.3s;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these over indented?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't look like it in my code, not sure why it's doing that....

@ccchwang ccchwang merged commit b30c061 into master Jan 11, 2018
@ccchwang ccchwang deleted the ch/lazy-load branch January 30, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants