Fix _onRelease binding in onDragOver handler #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Easy way to trigger an error is to add `draggable` attribute to the button in `example` and try to drag it. There will be a bunch of "Uncaught TypeError: Cannot read properties of undefined (reading 'state')" errors in the console
|
@cwmanning sorry to be a thorn, but this one looks pretty good too - is it possible to ship this as well? |
|
@cwmanning can we get this merged and released? We're hitting this bug at my company. |
|
Sure, sorry for the delay! Published as |
|
Thank you for the quick turnaround today, it's really appreciated 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Easy way to trigger an error is to add
draggableattribute to the button inexampleand try to drag it. There will be a bunch of "Uncaught TypeError: Cannot read properties of undefined (reading 'state')" errors in the console