-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add interop module for fs2 3.x #217
Conversation
Got a test failure, probably unrelated since it's a different module:
might be a flaky test. |
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=====================================
- Coverage 83% 82% -1%
=====================================
Files 12 11 -1
Lines 567 521 -46
Branches 5 4 -1
=====================================
- Hits 473 430 -43
+ Misses 94 91 -3 Continue to review full report at Codecov.
|
Nice! Will take a look at the flaky test |
Note: I fixed that flaky test |
I guess we're still stuck on the ZIO CE3 interop... |
Must be coming soon! :) |
Gonna revisit this soon, zio-interop released v3.0.2.0 with CE3 support. |
Hey, can we merge this? Don't worry about the flaky code coverage check :) I'm disabling it for now |
I wanted to update the docs to use the 3.x build, but if you want we can merge now :) |
Will close #215 when ready.
Note that there are no tests for now because ZIO interop isn't published yet, and I didn't want to change the whole test infra to use IO directly ;)
First commit is copy-pasting the 2.x version, second commit makes the necessary changes (for ease of review).