Staging v1.2.0 #38
Merged
Staging v1.2.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(outerClass): trim string to avoid adding empty class
Fix jumping scrollbar on open
✅ Deploy Preview for easy-popup ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
phucbm
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes multiple changes to the Easy Popup library, focusing on updating the version, enhancing documentation, adding new features, and improving the codebase. Below are the most important changes, grouped by theme.
Version Update and Documentation:
Updated version from 1.1.0 to 1.2.0 in
package.json,src/_style.scss, andREADME.mdto reflect the new release. [1] [2] [3]Added a new FAQ section in
dev/md/faq.mdto address common issues and provide solutions, such as fixing page jumps when the popup is shown.New Features:
Introduced
EasyPopup.setDev(isDev)method to enable or disable developer mode, allowing users to see console logs during development. [1] [2]Added a new
scrollbarWidthoption to the Easy Popup configuration to manually set the scrollbar width, preventing page jumps when a popup is opened. [1] [2]Codebase Improvements:
Moved
getScrollbarWidthfunction fromhelpers.jstoutils/getScrollbarWidth.jsto better organize utility functions. [1] [2]Added custom scrollbar styling in
dev/index.htmlto enhance the user interface.Bug Fixes and Enhancements:
Added checks to prevent double initialization of popups and log messages in developer mode for better debugging. [1] [2] [3]
Improved handling of the
preventScrolloption by adding detailed comments and logging for better clarity. [1] [2]Miscellaneous:
Updated README badges to reflect the new minified file size.
Added import for the new FAQ section in
dev/script.jsand included it in the HTML structure. [1] [2]These changes collectively enhance the functionality, usability, and maintainability of the Easy Popup library.