Skip to content

Commit

Permalink
net: Avoid calling getnameinfo when formatting IPv6 addresses in CNet…
Browse files Browse the repository at this point in the history
…Addr::ToStringIP
  • Loading branch information
practicalswift committed Apr 22, 2021
1 parent c10f27f commit 54548ba
Showing 1 changed file with 0 additions and 9 deletions.
9 changes: 0 additions & 9 deletions src/netaddress.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -615,15 +615,6 @@ std::string CNetAddr::ToStringIP() const
case NET_IPV4:
return IPv4ToString(m_addr);
case NET_IPV6: {
CService serv(*this, 0);
struct sockaddr_storage sockaddr;
socklen_t socklen = sizeof(sockaddr);
if (serv.GetSockAddr((struct sockaddr*)&sockaddr, &socklen)) {
char name[1025] = "";
if (!getnameinfo((const struct sockaddr*)&sockaddr, socklen, name,
sizeof(name), nullptr, 0, NI_NUMERICHOST))
return std::string(name);
}
return IPv6ToString(m_addr);
}
case NET_ONION:
Expand Down

0 comments on commit 54548ba

Please sign in to comment.