Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump sirv v3.0.0 #49

Merged
merged 1 commit into from
Jan 24, 2025
Merged

chore(deps): bump sirv v3.0.0 #49

merged 1 commit into from
Jan 24, 2025

Conversation

rtritto
Copy link
Contributor

@rtritto rtritto commented Jan 23, 2025

Fix dual package hazard

Verified

This commit was signed with the committer’s verified signature.
fwyzard Andrea Bocci
@brillout
Copy link
Member

Does this fix a concrete issue?

@rtritto
Copy link
Contributor Author

rtritto commented Jan 24, 2025

Yes, sirv@2.0.4 has the issue of dual package hazard that's fixed in v3.0.0:

The v3.0.0 also adds the node: protocol prefix to use Deno runtime:

@brillout
Copy link
Member

👍 Let's merge, please change the commit message to fix: update sirv.

@brillout brillout merged commit 1c877c9 into vikejs:main Jan 24, 2025
2 checks passed
@brillout
Copy link
Member

Nevermind, I did it.

@rtritto rtritto deleted the bump-sirv branch January 24, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants