-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "module" to package.json exports. #1382
Labels
enhancement ✨
New feature or request
Comments
Good question. I think the exports can indeed be improved. I'm not sure |
brillout
added a commit
that referenced
this issue
Mar 18, 2024
brillout
added a commit
that referenced
this issue
Mar 18, 2024
brillout
added a commit
that referenced
this issue
Mar 18, 2024
brillout
added a commit
that referenced
this issue
Mar 18, 2024
brillout
added a commit
that referenced
this issue
Mar 18, 2024
Done: I just added |
Also, would your company be up for sponsoring? |
Woop woop, appreciate it @brillout! I'll keep my eyes open for sponsors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Happy holidays!
Is there a reason why
module
is not one of the defined exports in the Vike package.json?vike/server
currently has the following exports:Adding
"module": "./dist/esm/node/runtime/index.js"
wouldn't take precedence over any of the others would it? Lost some time with this while bundling a dependency of Netlify functions. For now my workaround is to use Rollup with@rollup/plugin-node-resole
options set to{ exportConditions: ['node'] }
.The text was updated successfully, but these errors were encountered: