Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dynamic import example #488

Closed
wants to merge 8 commits into from

Conversation

arthurgailes
Copy link
Contributor

A working example submitted for inclusion here: https://vite-plugin-ssr.com/dynamic-import

resolves #487

@arthurgailes arthurgailes marked this pull request as ready for review October 26, 2022 16:33
@brillout
Copy link
Member

How about we move the example to github.com/arthurgailes? Also I'd add a readme then explaining how it works.

@arthurgailes
Copy link
Contributor Author

Understandable, feel free to close.

@brillout
Copy link
Member

We should still add a link in the docs though. An example is very much valuable (it's actually been on my to-do list).

Thanks for contributing an example!

@brillout
Copy link
Member

@arthurgailes Did you already move the example to you GitHub handle?

@arthurgailes
Copy link
Contributor Author

@brillout brillout closed this in f624220 Nov 3, 2022
@brillout
Copy link
Member

brillout commented Nov 3, 2022

Wonderful. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Dynamic Import example
2 participants