Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modal close "X" button with bootstrap 5.3.3 #714

Closed
XenoWizard opened this issue May 8, 2024 · 2 comments · Fixed by #729
Closed

Modal close "X" button with bootstrap 5.3.3 #714

XenoWizard opened this issue May 8, 2024 · 2 comments · Fixed by #729
Assignees
@gvreddy04
Labels
area-modal
Milestone
3.0.0-preview.1

Comments

@XenoWizard
Copy link

XenoWizard commented May 8, 2024 •
edited
Loading

image

To Reproduce
Steps to reproduce the behavior:

  1. Go to App.Razor and upgrade to bootstrap 5.3.3:

  2. Update the head:

<link href="https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/css/bootstrap.min.css" rel="stylesheet" integrity="sha384-QWTKZyjpPEjISv5WaRU9OFeRpok6YctnYmDr5pNlyT2bRjXh0JMhjY6hW+ALEwIH" crossorigin="anonymous">

  1. And body tags:

<script src="https://cdn.jsdelivr.net/npm/bootstrap@5.3.3/dist/js/bootstrap.bundle.min.js" integrity="sha384-YvpcrYf0tY3lHB60NNkmXc5s9fDVZLESaAA55NDzOxhy9GkcIdslK1eN7N6jIeHz" crossorigin="anonymous"></script>

Save and run. Now open up a modal with ShowCloseButton enabled. Close button in header slid to the left
@XenoWizard XenoWizard changed the title Modal Close Button Modal close "X" button now no longer renders in the correct spot. May 8, 2024
@XenoWizard XenoWizard changed the title Modal close "X" button now no longer renders in the correct spot. Modal close "X" button with bootstrap 5.3.3 May 8, 2024
@giarico
Copy link

giarico commented May 9, 2024

It's a bootstrap bug:
twbs/bootstrap#39798

It's going to be fixed in the next version.

@gvreddy04
Copy link
Contributor

@XenoWizard Thank you for using BlazorBootstrap. Mean while you can set HeaderCssClass="justify-content-between".

@gvreddy04 gvreddy04 added this to the 2.3.0 milestone May 18, 2024
gvreddy04 added a commit that referenced this issue May 18, 2024
@gvreddy04
Blazor 5.3.3 upgrade + Modal close "X" button with bootstrap 5.3.3 #714
ee673c8
@gvreddy04 gvreddy04 self-assigned this May 18, 2024
@gvreddy04 gvreddy04 linked a pull request May 22, 2024 that will close this issue
bootstrap v5.3.3 upgrade + demos + docs update #729
Merged
gvreddy04 added a commit that referenced this issue May 22, 2024
@gvreddy04
bootstrap v5.3.3 upgrade + demos + docs update (#729)
33ba26e 
* Blazor 5.3.3 upgrade + Modal close "X" button with bootstrap 5.3.3 #714

* Demos and Docs update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gvreddy04 gvreddy04

Labels
area-modal
Projects
None yet
Milestone
3.0.0-preview.1
Development

Successfully merging a pull request may close this issue.

bootstrap v5.3.3 upgrade + demos + docs update vikramlearning/blazorbootstrap
3 participants
@gvreddy04 @giarico @XenoWizard