fixed path to translation files in production build #675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbsrnt
approved these changes
May 10, 2021
|
Cleaning up the PR. Please do not merge yet. |
I tested it locally, on Linux. Before this change, the strings would load correctly when running a test build (npm start), but would fail to load when creating a production build (npm run build for example). Now, both builds seem to display text correctly.
|
I think it's clean now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it locally, on Linux. Before this change, the strings would load correctly when running a test build (npm start), but would fail to load when creating a production build (npm run build for example).
After the change, both builds seem to display text correctly.