Фидбэк мне давай ыуыъу #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vilunov
reviewed
Mar 12, 2020
| List(Khinkali(Stuffing.Beef, 7), Khinkali(Stuffing.Mutton, 3)) | ||
| } | ||
| def apply(n_customers: Int, | ||
| n_chefs: Int, |
There was a problem hiding this comment.
по скаловому кодстайлу поля должны быть в камелКейзе
| ctx.self ! Cook(order, replyToLater, customer) | ||
| cook | ||
| case Cook(order, waiter, customer) => | ||
| new Exception("Received COOK message while waiting for orders") |
There was a problem hiding this comment.
И че? throw наверное уж, ну и не хватает ctx.log.error
| client ! Customer.Eat | ||
| Behaviors.same | ||
| case Start => | ||
| println("Got a START message while already started. Very strange...") |
| cheese: (Double, Double)) | ||
|
|
||
| object Config { | ||
| private val cfg = ConfigFactory.load("application") |
There was a problem hiding this comment.
И лучше не указывать applicaiton. Typesafe Config ориентируется на иерархию конфигов, начиная с reference.conf, который таким образом не будет подгружаться. Плюс нет возможности указать другой конфиг, если нужны настройки для разных окружений. Просто используй - ConfigFactory.load(), а еще лучше не писать парсеры руками
|
|
||
| object Config { | ||
| private val cfg = ConfigFactory.load("application") | ||
| val rng: Random = new Random(cfg.getLong("seed")) |
There was a problem hiding this comment.
НЕЕЕЕТ глобальным мутабельным состояниям
|
Если будет не лень - чекните еще раз. Вроде поправил все дырки |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C:
:*