Skip to content

Support :const #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 31, 2019
Merged

Support :const #119

merged 7 commits into from
Jul 31, 2019

Conversation

tyru
Copy link
Member

@tyru tyru commented Jul 19, 2019

Fix #114

@tyru
Copy link
Member Author

tyru commented Jul 24, 2019

@mattn please review this

@tyru
Copy link
Member Author

tyru commented Jul 25, 2019

The job exceeded the maximum log length, and has been terminated.

only in "Vim master" 🤔
https://travis-ci.org/vim-jp/vim-vimlparser/jobs/563346598
But "Vim master" output is 1371 lines, "Vim v8" output is 1435 lines? 🤔

@blueyed do you know how to solve this?

@blueyed
Copy link
Contributor

blueyed commented Jul 25, 2019

The job exceeded the maximum log length, and has been terminated.

only in "Vim master"
https://travis-ci.org/vim-jp/vim-vimlparser/jobs/563346598
But "Vim master" output is 1371 lines, "Vim v8" output is 1435 lines?

Very odd. I've restarted them, but since the PR and push build failed, it likely will not help.

Maybe some special character that triggers this?
Normally it will allow like 10k lines of output, and no activity for 10 minutes.

@tyru
Copy link
Member Author

tyru commented Jul 31, 2019

restarted. it's all green now.
@mattn please review 🙏

Copy link
Member

@mattn mattn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tyru tyru merged commit 9cde691 into master Jul 31, 2019
@tyru
Copy link
Member Author

tyru commented Jul 31, 2019

Thanks! 🎉

@tyru tyru deleted the const branch July 31, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

const is missing
3 participants