Skip to content

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Jul 19, 2019

In Python it would use ord(), which does not work for "\e".

But apart from that viml_char2nr should probably be made to support/handle \e?
(Note however that "\e" is an invalid escape sequence in Python, so should be r"\e" there then)

blueyed added 2 commits July 19, 2019 17:29
In Python it would use `ord()`, which does not work for `"\e"`.
@mattn mattn self-requested a review July 19, 2019 15:37
@tyru
Copy link
Member

tyru commented Jul 19, 2019

I want to merge this but codecov failed?
I don't know codecov and how to see that info...

@blueyed
Copy link
Contributor Author

blueyed commented Jul 19, 2019

It "just" reports that the code in this PR/diff is not covered: https://codecov.io/gh/vim-jp/vim-vimlparser/compare/045da67d201b4f334c3c2ce0ad77abbf3a9be5ee...d3bca7fed5144d64959b86c59220e50d08d094c3

I've not checked if that's the case really (or if it is due to covimerage not handling this correctly) - but it should not block us from merging it.
It's just an indicator that the code is not tested, and would be more critical for new code (where it shows that a test is missing).

@blueyed
Copy link
Contributor Author

blueyed commented Jul 19, 2019

@tyru tyru merged commit 2d3ddf8 into vim-jp:master Jul 19, 2019
@tyru
Copy link
Member

tyru commented Jul 19, 2019

@blueyed Okay, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants