get_token_sq_c: skip char2nr for fixed values #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Python it would use `ord()`, which does not work for `"\e"`.
mattn
approved these changes
Jul 19, 2019
tyru
approved these changes
Jul 19, 2019
3 tasks
|
I want to merge this but codecov failed? |
|
It "just" reports that the code in this PR/diff is not covered: https://codecov.io/gh/vim-jp/vim-vimlparser/compare/045da67d201b4f334c3c2ce0ad77abbf3a9be5ee...d3bca7fed5144d64959b86c59220e50d08d094c3 I've not checked if that's the case really (or if it is due to covimerage not handling this correctly) - but it should not block us from merging it. |
|
@blueyed Okay, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Python it would use
ord(), which does not work for"\e".But apart from that
viml_char2nrshould probably be made to support/handle\e?(Note however that "\e" is an invalid escape sequence in Python, so should be
r"\e"there then)