Skip to content

Fix len() for js #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 20, 2019
Merged

Fix len() for js #130

merged 3 commits into from
Jul 20, 2019

Conversation

@mattn
Copy link
Member

@mattn mattn commented Jul 20, 2019

Fixes #129

@tyru tyru mentioned this pull request Jul 20, 2019
Closed
tyru
tyru approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@tyru tyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@mattn mattn merged commit e190e30 into master Jul 20, 2019
@mattn mattn deleted the fix-js-len branch July 20, 2019 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyru tyru tyru approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parse emoji error

2 participants

@mattn @tyru