Skip to content

WIP: Test python with 2.7, 3.4 #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

WIP: Test python with 2.7, 3.4 #132

wants to merge 5 commits into from

Conversation

tyru
Copy link
Member

@tyru tyru commented Jul 20, 2019 •
edited
Loading

Fix #131

The versions are used by Kuniwak/vint.

tyru added 2 commits July 21, 2019 02:24
@mattn
Copy link
Member

mattn commented Jul 20, 2019

LGTM

@tyru tyru changed the title Test python with 2.7, 3.4 WIP: Test python with 2.7, 3.4 Jul 20, 2019
@tyru
Copy link
Member Author

tyru commented Jul 20, 2019

@mattn sorry, I forgot to add "WIP" to title 😓
maybe 9012094 works perfect then... (waiting the result)

blueyed
blueyed reviewed Jul 20, 2019
View reviewed changes
Makefile
test/run_command.sh python py/vimlparser.py
for python in $(VIMLPARSER_PYTHON_LIST); do \
test/run_command.sh $$python py/vimlparser.py; \
done
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this only checks for syntax errors I assume?

We would get this also when using flake8 (i.e. the "checkpy" target, #122) - not sure if it would need to run flake8 both via py2 and py3 (usually using py3 only is fine).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumption was wrong - it actually runs tests, and it makes sense to have this then with py2 and py3 I guess.

@blueyed
Copy link
Contributor

blueyed commented Jul 20, 2019

I'd rather do this via / with #122.
The flake8 check there might be enough already.

But for doing this explicitly, you could probably just use "python3" explicitly.

@blueyed
Copy link
Contributor

blueyed commented Jul 20, 2019 •
edited
Loading

As for vint, it tests with py27, and py{34,35,36,37) - but that's really not necessary here.

@tyru
Copy link
Member Author

tyru commented Jul 20, 2019

Okay, so can you take this over in #122 ?
Then I'll close this PR.

@blueyed blueyed mentioned this pull request Jul 20, 2019
Merged
3 tasks
@blueyed
Copy link
Contributor

blueyed commented Jul 20, 2019

@tyru
Added to the TODO there.

@blueyed blueyed closed this Jul 20, 2019
@blueyed blueyed deleted the test-python3 branch July 20, 2019 21:00
@tyru
Copy link
Member Author

tyru commented Jul 21, 2019

Thanks!

@blueyed
Copy link
Contributor

blueyed commented Jul 31, 2019

Done in #134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blueyed blueyed blueyed left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test in Python 3 on CI
3 participants
@tyru @mattn @blueyed