Skip to content

ci: coverage for Python #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 12, 2019
Merged

ci: coverage for Python #146

merged 2 commits into from
Aug 12, 2019

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 11, 2019

No description provided.

@blueyed blueyed changed the title [WIP] ci: coverage for Python ci: coverage for Python Aug 11, 2019
@blueyed

This comment has been minimized.

Sign in to view
@blueyed blueyed requested a review from tyru August 11, 2019 23:50
@blueyed

This comment has been minimized.

Sign in to view
@blueyed
Travis: use "vim --version"
ab6c127 
This avoids output issues.
@blueyed
Copy link
Contributor Author

blueyed commented Aug 12, 2019

Better/good: https://codecov.io/gh/vim-jp/vim-vimlparser/src/3d5ec96e4fc0973fa0a0327ec6af2bacf6f91db4/py/vimlparser.py

tyru
tyru approved these changes Aug 12, 2019
View reviewed changes
Copy link
Member

@tyru tyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@blueyed
Copy link
Contributor Author

blueyed commented Aug 12, 2019

@tyru
I cannot merge it myself.
But it is OK to wait a bit for other feedback if that's what you want.

@blueyed blueyed mentioned this pull request Aug 12, 2019
Open
@tyru tyru merged commit b9af237 into vim-jp:master Aug 12, 2019
@tyru
Copy link
Member

tyru commented Aug 12, 2019

I thought you had permission to merge.
merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyru tyru tyru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blueyed @tyru