-
Notifications
You must be signed in to change notification settings - Fork 25
allow leading spaces for heredoc end marker #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
84054c9
to
33b150f
Compare
sorry for the excessive force pushes, realized I forgot to handle |
I added some more test coverage that should bring the patch coverage to 100% and prevent decreasing the overall test coverage percentage. I also had added some negative test cases, unfortunately the line numbers returned in the errors are off by one between the javascript and the python/vim (which are consistent with each other). For example, I got the following result for one of my tests:
|
@mattn is there anything that is blocking this change (other than merge conflicts)? Would be happy to make a revision if you would accept this patch with some revisions. |
Thank you. Looks good to me. Could you please resolve conflicts? |
@mattn merged master rerunning |
Thank you. |
The extra test cases that I include in
test_heredoc.vim
are accepted by vim (you can check by doing:source test/test_heredoc.vim
but aren't accepted by this library and result in a parse error.This was annoying me by making it impossible to lint a file in my vim config that extensively uses the
let =<<
heredocs withvint
.Fixes #188.
let =<<
was already supported, but I thought it wasn't because the correct behavior fortrim
wasn't implemented.