vitalizer: Wrap function() to ignore error when creating module function list #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vim-jp-bot
reviewed
Nov 23, 2017
data/vital/autoloadablize.vim
Outdated
| return matchstr(expand('<sfile>'), '<SNR>\zs\d\+\ze__SID$') | ||
| endfunction | ||
| execute join(['function! ${autoload_import}() abort', printf("return map(${funcdict}, \"vital#_${plugin_name}#function('<SNR>%s_' . v:key)\")", s:_SID()), 'endfunction'], "\n") | ||
| delfunction! s:_SID |
There was a problem hiding this comment.
[vint] reported by reviewdog 🐶
E477: No ! allowed (see ynkdir/vim-vimlparser)
Problem: delfunction s:_SID causes unexpected following error: "E130: Unknown function: s:_SID" It seems this error occurs because 'delfunction' is executed twice. Root cause: sourceing an autoload file will source same file unexpectedly in the middle of first source process on defining autoload function. 1. Start sourcing autoload/hoge.vim 2. When executing line 2, Vim stops executing following scripts and Vim starts sourcing same file from at the beginning of autoload/hoge.vim and execute whole files. (echom at line 4 is executed. 3. Restart sourcing autoload/hoge.vim from line 3. 4. echom at line 4 is executed at second time. autoload/hoge.vim: 1 | " hoge.vim 2 | function! hoge#foo() 3 | endfunction 4 | echom 'hoge.vim is sourced'
|
I updated the commit message to describe why we switched to use try-catch when calling |
This was referenced Nov 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function list is generated on Vitalize and
#import()func is called in users environment, some function might not be defined as script local function andfunction('s:{funcname}')will throw errors.Fix #537