Skip to content

multiple smart punctuation fixes #312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

multiple smart punctuation fixes #312

wants to merge 2 commits into from

Conversation

rwxrob
Copy link

@rwxrob rwxrob commented Jan 25, 2020

Still needs strike but otherwise quotes are golden in headers and elsewhere.

@rwxrob rwxrob requested a review from alerque January 25, 2020 22:42
Plugin 'vim-pandoc/vim-pandoc-syntax'
```

Run `:PluginInstall` after making the changes from within a `vim` session, or you can just run `vim +':PlugInstall' +':q!' +':q!'` from the command line.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run `:PluginInstall` after making the changes from within a `vim` session, or you can just run `vim +':PlugInstall' +':q!' +':q!'` from the command line.
Run `:PluginInstall` after making the changes and reloading your rc file from within a `vim` session, or you can just run `vim +PlugInstall +UpdateRemotePlugins +all +qa` from the command line.

![img2](http://i.imgur.com/z8FpxRP.png)
![img3](http://i.imgur.com/ziNjQiE.png)
![img4](http://i.imgur.com/UKoOxzP.png)
![img1](doc/UKXbG2V.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert these changes and drop the image blobs from the commit(s)? For now I think I'd rather leave these out-of-band. One you put screenshots in a plugin they follow the repository around literally forever, and if you update them people start having multiple versions of the images in their repositories. Given that I check out my plugins on all sorts of machines, that starts adding up space and bandwidth for very little gain.

@alerque
Copy link
Member

alerque commented Jan 27, 2020

Thanks for taking the time to contribute this @rwxrob. The bulk of the vim stuff looks alright at first pass (although I haven't tested it in action yet), but I have a couple requests in regard to the Readme changes. If you can, I'd like to see the unrelated changes about plugin managers etc. in a separate commit (in case something goes haywire and we have to git bisect or revert). Are you familiar with rebasing? The easiest tool for that job by the way is git revise -c to split at existing commit by hunks.

@rwxrob
Copy link
Author

rwxrob commented Jan 27, 2020

Hope it's okay to just close this request and open a new one #313 with only the changes you suggest. I'm not (yet) acquainted with rebase and revise but will focus on it for next time.

I understand now your reason for not including images. That makes a lot of sense.

There is another bug with relation to ::: divs that I would like to work on later as well. Perhaps I'll submit the report first so we can track it. Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants