fix interpretation of TOP in syn included file
#8104
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `syn include @name FILE`, the `TOP` in the sourced `FILE` should be interpreted as `@NAME`, not the `TOP` of the caller. For example, consider markdown fenced code block containing C code. To highlight the C code in the block, we would write something like this in syntax/markdown.vim: syn include @FENCED_C syntax/c.vim syn region start="```c" end="```" contains=@FENCED_C In this case, this line in $VIMRUNTIME/syntax/c.vim syn region cCppOutElse ... contains=TOP,... should be should be interpreted as syn region cCppOutElse ... contains=@FENCED_C,... because we want `cCppOutElse` to contain the `TOP` of C syntax, not the `TOP` of markdown syntax.
Codecov Report
@@ Coverage Diff @@
## master #8104 +/- ##
==========================================
- Coverage 89.34% 88.90% -0.44%
==========================================
Files 148 144 -4
Lines 166205 164947 -1258
==========================================
- Hits 148488 146647 -1841
- Misses 17717 18300 +583
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
You have examples, so perhaps you can turn them into a test? |
tomtomjhj
force-pushed
the
syn-include-TOP
branch
2 times, most recently
from
c40649f to
7d9b812
Compare
tomtomjhj
force-pushed
the
syn-include-TOP
branch
from
7d9b812 to
efbe78e
Compare
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Apr 14, 2021
Problem: Using "syn include" does not work properly.
Solution: Don't add current_syn_inc_tag to topgrp. (Jaehwang Jerry Jung,
closes vim/vim#8104)
vim/vim@2e240bd
Cherry-pick AssertHighlightGroups from patch v8.2.2068.
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Apr 14, 2021
Problem: Using "syn include" does not work properly.
Solution: Don't add current_syn_inc_tag to topgrp. (Jaehwang Jerry Jung,
closes vim/vim#8104)
vim/vim@2e240bd
Cherry-pick AssertHighlightGroups from patch v8.2.2068.
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Apr 15, 2021
Problem: Using "syn include" does not work properly.
Solution: Don't add current_syn_inc_tag to topgrp. (Jaehwang Jerry Jung,
closes vim/vim#8104)
vim/vim@2e240bd
Cherry-pick AssertHighlightGroups from patch v8.2.2068.
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Apr 15, 2021
Problem: Using "syn include" does not work properly.
Solution: Don't add current_syn_inc_tag to topgrp. (Jaehwang Jerry Jung,
closes vim/vim#8104)
vim/vim@2e240bd
Cherry-pick AssertHighlightGroups from patch v8.2.2068.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
syn include @NAME FILE, theTOPin the sourcedFILEshould be interpreted as
@NAME, not theTOPof the caller.For example, consider markdown fenced code block containing C code. To
highlight the C code in the block, we would write something like this in
syntax/markdown.vim:
In this case, this line in $VIMRUNTIME/syntax/c.vim
should be should be interpreted as
because we want
cCppOutElseto contain theTOPof C syntax, not theTOPof markdown syntax.