Skip to content

Commit

Permalink
Update setup.py (rapidsai#4015)
Browse files Browse the repository at this point in the history
This PR includes some changes that were necessary to build `cuml` via CMake. Namely it includes the following changes:

- Updates the `libs` list to include some additionally libraries to link against
- Moves the `runtime_library_dirs` to `library_dirs`

cc: @trxcllnt, who helped me get `cuml` built via CMake

Authors:
  - AJ Schmidt (https://github.com/ajschmidt8)

Approvers:
  - Dante Gama Dessavre (https://github.com/dantegd)

URL: rapidsai#4015
  • Loading branch information
ajschmidt8 authored Jun 30, 2021
1 parent e81da5c commit 8b91691
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions python/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ def finalize_options(self):
# object has all the args used by the user, we can check that.
self.singlegpu = '--singlegpu' in self.distribution.script_args

libs = ['cuml++']
libs = ['cuml++', 'cudart', 'cusparse', 'cusolver']

include_dirs = [
'../cpp/src',
Expand Down Expand Up @@ -184,9 +184,11 @@ def finalize_options(self):
Extension("*",
sources=["cuml/**/*.pyx"],
include_dirs=include_dirs,
library_dirs=[get_python_lib(), libcuml_path],
runtime_library_dirs=[
cuda_lib_dir, os.path.join(os.sys.prefix, "lib")
library_dirs=[
get_python_lib(),
libcuml_path,
cuda_lib_dir,
os.path.join(os.sys.prefix, "lib")
],
libraries=libs,
language='c++',
Expand Down

0 comments on commit 8b91691

Please sign in to comment.