Remove custom proxy-metrics code. #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plietar
force-pushed
the
cleanup-proxy-metrics
branch
from
108f88b to
ab2469a
Compare
The only reason we had a custom implementation for proxy-metrics was because constellation used to start containers without any networking, and would only attach to the network as a second step, which broke the proxy's expectation. This issue was solved in reside-ic/constellation#23. Thanks to this we can simplify our setup and use the standard declarative approach even for the proxy-metrics container.
plietar
force-pushed
the
cleanup-proxy-metrics
branch
2 times, most recently
from
fef3ad5 to
d05f3c3
Compare
plietar
force-pushed
the
cleanup-proxy-metrics
branch
from
d05f3c3 to
22951f7
Compare
plietar
force-pushed
the
cleanup-proxy-metrics
branch
from
e9fbb49 to
62ffa2d
Compare
|
The tests diff looks pretty big because I moved a lot of it inside of If you ask GitHub to ignore whitespace it is a bit better. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
==========================================
- Coverage 99.43% 99.36% -0.07%
==========================================
Files 4 4
Lines 355 316 -39
Branches 42 36 -6
==========================================
- Hits 353 314 -39
Partials 2 2 ☔ View full report in Codecov by Sentry. |
richfitz
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only reason we had a custom implementation for proxy-metrics was because constellation used to start containers without any networking, and would only attach to the network as a second step, which broke the proxy's expectation. This issue was solved in reside-ic/constellation#23.
Thanks to this we can simplify our setup and use the standard declarative approach even for the proxy-metrics container.