Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First add repo, then run deployment #3

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Conversation

mpraski
Copy link

@mpraski mpraski commented Jan 25, 2021

Run two commands:

  1. (Optionally) add a helm repository
  2. Run the deployment

The current code doesn't work as we're passing effectively two commands to exec.exec('helm', args) in the args array. It's cleaner to separate them in two functions and then execute sequentially.

@mpraski mpraski added the bug Something isn't working label Jan 25, 2021
@mpraski mpraski requested a review from italolelis January 25, 2021 15:12
@mpraski mpraski self-assigned this Jan 25, 2021
@mpraski mpraski merged commit caab363 into master Jan 25, 2021
@mpraski mpraski deleted the run-multiple-commands branch January 25, 2021 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants