Only emit PossiblyUndefinedVariable issue on variables

vimeo · Mar 6, 2020 · 7ea06c7 · 7ea06c7
1 parent 75a3412
commit 7ea06c7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 1 deletion.
diff --git a/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php b/src/Psalm/Internal/Analyzer/Statements/Expression/CallAnalyzer.php
@@ -707,7 +707,9 @@ private static function evaluateAribitraryParam(
             if (!$context->hasVariable($var_id, $statements_analyzer)
                 || $context->vars_in_scope[$var_id]->isNull()
             ) {
-                if (!isset($context->vars_in_scope[$var_id])) {
+                if (!isset($context->vars_in_scope[$var_id])
+                    && $arg->value instanceof PhpParser\Node\Expr\Variable
+                ) {
                     if (IssueBuffer::accepts(
                         new PossiblyUndefinedVariable(
                             'Variable ' . $var_id

diff --git a/tests/MethodCallTest.php b/tests/MethodCallTest.php
@@ -524,6 +524,17 @@ public function give(): void{
                         }
                     }',
             ],
+            'unknownMethodCallWithProperty' => [
+                '<?php
+                    class A {
+                        private string $b = "c";
+
+                        public function passesByRef(object $a): void {
+                            /** @psalm-suppress MixedMethodCall */
+                            $a->passedByRef($this->b);
+                        }
+                    }',
+            ],
         ];
     }