Support string class_alias calls with leading backslash

Fixes #3465
vimeo · May 27, 2020 · b9ea115 · b9ea115
1 parent ef53ee3
commit b9ea115
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 0 deletions.
diff --git a/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php b/src/Psalm/Internal/PhpVisitor/ReflectorVisitor.php
@@ -947,6 +947,14 @@ private function registerClassMapFunctionCall(
             }
 
             if ($first_arg_value !== null && $second_arg_value !== null) {
+                if ($first_arg_value[0] === '\\') {
+                    $first_arg_value = substr($first_arg_value, 1);
+                }
+
+                if ($second_arg_value[0] === '\\') {
+                    $second_arg_value = substr($second_arg_value, 1);
+                }
+
                 $second_arg_value = strtolower($second_arg_value);
 
                 $this->codebase->classlikes->addClassAlias(

diff --git a/tests/TryCatchTest.php b/tests/TryCatchTest.php
@@ -320,6 +320,31 @@ class_alias(
 
                     namespace Client;
 
+                    try {
+                        throw new \Alias\UserException\UserExceptionAlias();
+                    } catch (\Alias\UserException\UserExceptionAlias $e) {
+                        // do nothing
+                    }'
+            ],
+            'aliasAnotherException' => [
+                '<?php
+                    namespace UserException;
+
+                    class UserException extends \Exception {
+
+                    }
+
+                    namespace Alias\UserException;
+
+                    use function class_alias;
+
+                    class_alias(
+                        \UserException\UserException::class,
+                        \'\Alias\UserException\UserExceptionAlias\'
+                    );
+
+                    namespace Client;
+
                     try {
                         throw new \Alias\UserException\UserExceptionAlias();
                     } catch (\Alias\UserException\UserExceptionAlias $e) {