Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .gitattributes #10645

Closed
wants to merge 1 commit into from
Closed

Update .gitattributes #10645

wants to merge 1 commit into from

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Feb 3, 2024

Hello there,

When downloading a snapshot archive from Github (example: https://github.com/vimeo/psalm/archive/refs/heads/5.x.zip) based on a specific commit ID, branch or tag for example, it is not possible to build PSalm because the /examples directory is missing, and it is required in composer.json (https://github.com/vimeo/psalm/blob/5.x/composer.json#L100).

This PR update the .gitattributes file so it doesn't get stripped out by Github.

@drupol drupol marked this pull request as ready for review February 3, 2024 12:46
@weirdan
Copy link
Collaborator

weirdan commented Feb 3, 2024

Do you mean the phar build?

@drupol
Copy link
Contributor Author

drupol commented Feb 3, 2024

Yes,

The PHAR build, or just a regular build. Since it is mentioned in the composer.json, it shouldn't be stripped out.

@drupol
Copy link
Contributor Author

drupol commented Feb 3, 2024

Closed in favor of #10647

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants