Add ReflectionProperty::getType() and hasType()

[franmomu]

This PR tries to do as c97ee5c for ReflectionProperty adding ReflectionProperty::hasType() and ReflectionProperty::getType().

Right now: https://psalm.dev/r/b00d652573

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/b00d652573

<?php

$method = new ReflectionClass(stdClass::class);
$properties = $method->getProperties();
foreach ($properties as $property) {
	if ($property->hasType()) {
		$property->getType()->__toString();
	}
}

Psalm output (using commit 6851b5c):

ERROR: UndefinedMethod - 6:17 - Method ReflectionProperty::hasType does not exist

ERROR: PossiblyNullReference - 7:25 - Cannot call method __toString on possibly null value

[franmomu]

I forgot I started this one, so tests fail and the only thing I can think of is that ReflectionParameter is immutable, but ReflectionProperty is not. Any help? 🤔

[caugner]

@franmomu Unfortunately The logs for this run have expired and are no longer available.. Would you be able to amend & force-push to re-trigger the checks?

[franmomu]

@franmomu Unfortunately The logs for this run have expired and are no longer available.. Would you be able to amend & force-push to re-trigger the checks?

Sure, done! Feel free to try it, the problem I think it was immutability, ReflectionProperty has a setValue method so it cannot be immutable, don't know if there is other way.

[caugner]

Sure, done!

Thanks.

There was 1 error:
  
1) Psalm\Tests\AssertAnnotationTest::testValidCode with data set "implicitReflectionPropertyAssertion" ('<?php\n                    $c...     }')
   Psalm\Exception\CodeException: MixedMethodCall - src/somefile.php:6:51 - Cannot determine the type of the object on the left hand side of this expression

And this is line 6:

$property->getType()->allowsNull();

Alright, now I see what you mean. Since $property cannot be declared immutable, Psalm doesn't use assert-if-true from $property->hasType() to determine the type of $property->getType(). 😦

I wonder if it would help to mark hasType() and getType() with @psalm-mutation-free. But still, even if $property is not immutable, Psalm should be able to determine that the assertion by hasType() is true at least immediately for the next statement.

[weirdan]

MixedMethod is caused by Psalm thinking you're targeting a PHP version below 7.4. You need to mark the test case as targeting 7.4.

[caugner]

You need to mark the test case as targeting 7.4.

Here's an example (I think):

psalm/tests/Template/ClassTemplateExtendsTest.php

Lines 3442 to 3488 in 9a0f9f9

	'implementExtendedInterfaceWithMethodOwnTemplateParams' => [
	'<?php
	/**
	* @template T1
	*/
	interface IFoo {
	/**
	* @template T2
	* @psalm-param T2 $f
	* @psalm-return self<T2>
	*/
	public static function doFoo($f): self;
	}
	/**
	* @template T3
	* @extends IFoo<T3>
	*/
	interface IFooChild extends IFoo {}
	/**
	* @template T5
	* @implements IFooChild<T5>
	*/
	class ConcreteFooChild implements IFooChild {
	/** @var T5 */
	private $baz;
	/** @param T5 $baz */
	public function __construct($baz) {
	$this->baz = $baz;
	}
	/**
	* @template T6
	* @psalm-param T6 $f
	* @psalm-return ConcreteFooChild<T6>
	*/
	public static function doFoo($f): self {
	$r = new self($f);
	return $r;
	}
	}',
	[],
	[],
	'7.4'
	],

[franmomu]

MixedMethod is caused by Psalm thinking you're targeting a PHP version below 7.4. You need to mark the test case as targeting 7.4.

Here's an example (I think):

psalm/tests/Template/ClassTemplateExtendsTest.php

Lines 3442 to 3488 in 9a0f9f9

	'implementExtendedInterfaceWithMethodOwnTemplateParams' => [
	'<?php
	/**
	* @template T1
	*/
	interface IFoo {
	/**
	* @template T2
	* @psalm-param T2 $f
	* @psalm-return self<T2>
	*/
	public static function doFoo($f): self;
	}
	/**
	* @template T3
	* @extends IFoo<T3>
	*/
	interface IFooChild extends IFoo {}
	/**
	* @template T5
	* @implements IFooChild<T5>
	*/
	class ConcreteFooChild implements IFooChild {
	/** @var T5 */
	private $baz;
	/** @param T5 $baz */
	public function __construct($baz) {
	$this->baz = $baz;
	}
	/**
	* @template T6
	* @psalm-param T6 $f
	* @psalm-return ConcreteFooChild<T6>
	*/
	public static function doFoo($f): self {
	$r = new self($f);
	return $r;
	}
	}',
	[],
	[],
	'7.4'
	],

Thanks! done

[franmomu]

@caugner I think it works with the @psalm-mutation-free you said 👍 (apart from adding the 7.4 check)

[caugner]

Just to check: Did you need to add mutation-free to make the test pass? So marking the test with 7.4 was not enough?

[franmomu]

Yes, without: https://psalm.dev/r/5d10995beb
with: https://psalm.dev/r/8e9b30898d

[caugner]

Thanks, glad to hear it works! This reminds me that I should use that annotation in my own projects as well. 🙂

[weirdan]

Thanks, looking good!