Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Initial Support for LSP Code Actions #7255

Merged
merged 5 commits into from
Jan 2, 2022

Conversation

tm1000
Copy link
Contributor

@tm1000 tm1000 commented Dec 30, 2021

This adds initial support for Code Actions in the Language Server.

Code actions allow a user in their respective IDE to right click an error and implement a "quickfix".

The initial work only implements the ability to suppress errors. The reasoning for this is because it seems difficult in Psalms current state to query the diff from Psalter while running in the Language server (More investigation needs to be done here.

Here's an example of this working in VSCode using: https://github.com/psalm/psalm-vscode-plugin

Screen.Recording.2021-12-30.at.3.16.45.PM.mov

The next steps after this would be to enable the ability to auto fix issues from Psalter.

@tm1000 tm1000 changed the title [Feat]: Initial Support for Code Actions [Feat]: Initial Support for LSP Code Actions Dec 31, 2021
@tm1000
Copy link
Contributor Author

tm1000 commented Dec 31, 2021

@joehoyle thoughts? As you've worked on the LSP in the past as well

@weirdan weirdan added the release:feature The PR will be included in 'Features' section of the release notes label Jan 2, 2022
@weirdan weirdan merged commit ab30a36 into vimeo:master Jan 2, 2022
@weirdan
Copy link
Collaborator

weirdan commented Jan 2, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants