Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump slevomat/coding-standard #8783

Merged
merged 1 commit into from
Nov 27, 2022

Conversation

weirdan
Copy link
Collaborator

@weirdan weirdan commented Nov 27, 2022

This prevents issues with incompatible phpstan/phpdoc-parser.

slevomat/coding-standard:8.3 claimed compatibility with
phpstan/phpdoc-parser:^1.6, but it fails with a fatal error when
phpstan/phpdoc-parser:1.14 is installed (apparently there was a BC
break in a minor version of phpstan/phpdoc-parser).

Since 8.4 slevomat/coding-standard adopted a more conservative
dependency strategy, and they don't allow new untested versions of
phpstan/phpdoc-parser.

8.4 still allows PHP 7.2, so we should have no problems due to 7.x
removal.

This prevents issues with incompatible `phpstan/phpdoc-parser`.

`slevomat/coding-standard:8.3` claimed compatibility with
`phpstan/phpdoc-parser:^1.6`, but it fails with a fatal error when
`phpstan/phpdoc-parser:1.14` is installed (apparently there was a BC
break in a minor version of `phpstan/phpdoc-parser`).

Since 8.4 slevomat/coding-standard adopted a more conservative
dependency strategy, and they don't allow new untested versions of
`phpstan/phpdoc-parser`.

8.4 still allows PHP 7.2, so we should have no problems due to 7.x
  removal.
@weirdan weirdan added the release:internal The PR will be included in 'Internal changes' section of the release notes label Nov 27, 2022
@weirdan weirdan merged commit 94dac9f into vimeo:master Nov 27, 2022
@weirdan weirdan deleted the bump-slevomat-coding-standard branch November 27, 2022 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:internal The PR will be included in 'Internal changes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant