Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow the hash param to be a string or a boolean. #29

Merged

Conversation

francois2metz
Copy link
Contributor

Since the version 1.5.0, vue-mapbox allow the hash param to be a boolean or a string.

Same code as soal/vue-mapbox#155

@vinayakkulkarni vinayakkulkarni changed the title Allow the hash param to be a string or a boolean. feat: allow the hash param to be a string or a boolean. Jun 22, 2020
@vinayakkulkarni
Copy link
Owner

Hey @francois2metz,

Thanks for this PR, but you need to rebase and reword your commit as this repo follows the commitlint convention.

$ git rebase -i HEAD~1

Then in the vim editor, reword

- Allow the hash param to be a string or a boolean.
+ feat: allow the hash param to be string or boolean

Then push it to your fork

$ git push --force

@vinayakkulkarni vinayakkulkarni added enhancement New feature or request documentation Improvements or additions to documentation labels Jun 22, 2020
@vinayakkulkarni
Copy link
Owner

LGTM

@vinayakkulkarni vinayakkulkarni merged commit 3b24f13 into vinayakkulkarni:master Jun 22, 2020
@francois2metz francois2metz deleted the hash-as-string branch June 22, 2020 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants