Add text watcher to dynamically change phone number input type #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
This changes the default inputType of the phone number input field to "phone" and adds a TextWatcher to observe for changes to the input field (either manual user edits or programmatic changes from extracting text out of intent launches or history item clicks). This allows users who share text with Launch Chat to edit the text (using the "text" soft keyboard) before clicking one of the action buttons, while also aiding users who directly launch Launch Chat in typing a phone number (using the "phone" soft keyboard)
vinaygopinath
force-pushed
the
keyboard-input-type
branch
from
5d20725
to
abc170f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default inputType of the phone number input field to "phone" and adds a TextWatcher to observe for changes to the input field (either manual user edits or programmatic changes from extracting text out of intent launches or history item clicks).
This allows users who share text with Launch Chat to edit the text (using the "text" soft keyboard) before clicking one of the action buttons, while also aiding users who directly launch Launch Chat in typing a phone number (using the "phone" soft keyboard)
launch-chat-dynamic-input-type.mp4