-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmp-serde
support & docs for features
#71
Conversation
@leontoeides thanks you very much for your PR! Can you re-write your commit names with the conventionalcommits format? To do it you can use |
Yes, I made quite a mess with all the commits. My git skills are the bare minimum. But, thanks, today I learned that there is a way to clean these types of messes up. There is a way to "squash" commits together, but I'm thinking it might be too late for that? I'm seeing your commits in my squash list. Seems dangerous. I hope this works well enough |
@leontoeides Thank you for renaming the commit; it's the "right way to do it." However, keep in mind that it depends on the project. In fact, everyone does as they wish/can. But now, I have the impression that there was a problem during the rebase (unresolved git conflicts) which is causing issues in your code. For example I saw that in your PR, you were trying to do several things: adding documentation, fixing the documentation of features (related to this issue #70), adding custom encode/decode |
Close in favor of #79 |
Sized
bounds already declared in the traitrmp-serde