Adição de mensagem quando pix estiver fora de ar na hora de renovar QRCode #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 94e8bd7.
Co-authored-by: Ana Catharina Mesquita <catha.ana.1994@gmail.com>
Co-authored-by: Ana Catharina Mesquita <catha.ana.1994@gmail.com>
leydiane-matias-vindi
requested review from
leo-araujo,
a team and
ozavanelli
and removed request for
a team
leo-araujo
approved these changes
Nov 25, 2022
|
Olá @vinidziuba Tudo bem? Poderia atualizar a corpo do PR com uma descrição sobre a mudança? |
vinidziuba
requested review from
leo-araujo
and removed request for
ozavanelli
|
@acmesquita Feito |
acmesquita
reviewed
Nov 29, 2022
Controller/Pix/Renew.php
Outdated
| @@ -67,18 +67,20 @@ public function execute() | |||
| $this->orderRepository->save($order); | |||
| $this->messageManager->addSuccessMessage(__("QR Code atualizado")); | |||
| return $resultRedirect; | |||
| } else { | |||
| $this->messageManager->addErrorMessage(__("Não foi possivel atualizar o QR Code. Tente novamente mais tarde.")); | |||
There was a problem hiding this comment.
Como é a mesma mensagem repedida várias vezes, o que acha de colocar uma variável?
There was a problem hiding this comment.
@acmesquita Feito !
leo-araujo
approved these changes
Nov 29, 2022
acmesquita
approved these changes
Dec 1, 2022
carolineesteves
pushed a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Sep 13, 2024
fix: adjusting BillPaid webhook flow for when it is subscription and when it is not
carolineesteves
pushed a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Sep 13, 2024
Merge pull request vindi#103 from cedran/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que mudou
Adição de novas mensagens de erro para pix fora do ar
Motivação
Informar cliente que não foi possivel gerar o QRCODE
Solução proposta
Adicionar mensagens naa validação de geração de QRCode
Como testar
Tentar gerar um qrcode expirado , quando pix estiver fora do ar.