Tratado pedidos de assinatura com retorno da Vindi sem o atributo bill #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thais-kusuki-vindi
requested review from
thais-kusuki-vindi,
leo-araujo and
rai-gondim-vindi
|
O Thiago criou um novo PR com essas alterações para subir juntas com outras tarefas. |
carolineesteves
pushed a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Sep 13, 2024
fix: PRODUTOS (1) e (2) - ajuste de cadastro de planos ao salvar produtos
carolineesteves
pushed a commit
to bizcommerce/vindi-magento2
that referenced
this pull request
Sep 13, 2024
Merge pull request vindi#106 from cedran/master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que mudou
Alterado a validação de pedido de assinatura criado na Vindi para permitir pedidos sem o atributo "bill".
Motivação
Pedidos com o tipo de cobrança da assinatura posterior a data atual o eram criados na Vindi mas não no Magento.
Solução proposta
Tratar a validação do retorno da chamada "subscriptions" para permitir pedidos onde a fatura ainda não foi criada.
Como testar
Criar uma assinatura com o Tipo de Cobrança ("billing_trigger_type") de Início do Período, e Quando ("billing_trigger_day") maior que 0. Após isso tentar realizar um pedido desta assinatura.