Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/replace requests with urllib3 #167

Merged
merged 3 commits into from
Jan 8, 2023

Conversation

vinitkumar
Copy link
Owner

@vinitkumar vinitkumar commented Jan 6, 2023

  • Remove requests as a dependency and use urllib3, since it much better development and funded as well.

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Base: 94.02% // Head: 94.04% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (309795c) compared to base (18a5c19).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #167      +/-   ##
==========================================
+ Coverage   94.02%   94.04%   +0.01%     
==========================================
  Files           6        6              
  Lines         536      537       +1     
==========================================
+ Hits          504      505       +1     
  Misses         32       32              
Impacted Files Coverage Δ
json2xml/utils.py 86.04% <100.00%> (+0.33%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinitkumar vinitkumar merged commit e03e7ed into master Jan 8, 2023
@vinitkumar vinitkumar deleted the feat/replace-requests-with-urllib3 branch January 8, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant