-
-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Css classes refactor #171
Css classes refactor #171
Conversation
@Engineering-Robert Would really appreciate if you can keep the PRs smaller. Smaller PRs are easier to review and more possible to spot bugs that way. Also, different issues deserve different PRs as they keep the context clear. Another thing, I am travelling today and tomorrow so most probably be online only on Sunday. |
Ya, this one got quite lengthy, my apologies. However, I did want to get all this work within this pull request since I wanted you to merge all of this today. The alternative would have been to do half the work, make a PR, wait for you to merge, do the other work, make another PR, have you merge the PR. |
I did not mean to merge this. I thought I was on my forked repository! I'm trying to revert it right now. |
Well. I think I am only interested in reviewing breaking changes. As long
as you are doing think that are an enhancement. I am pretty cool with you
merging it. Also, even when you are merging it. Try and keep your PR small.
It helps to debug things in case something brakes. Also, bi changes must be
done in phases. So plan your work accordingly. It might sound tedious. But
believe me, it helps a lot in maintaining the software and finding bugs
quickly.
On 20-Oct-2017 11:19 AM, "Robert Cooper" <notifications@github.com> wrote:
Ya, this one got quite lengthy, my apologies. However, I did want to get
all this work within this pull request since I wanted you to merge all of
this today. The alternative would have been to do half the work, make a PR,
wait for you to merge, do the other work, make another PR, have you merge
the PR.
I see two possible solutions to the above problem, and that would be to
either merge the smaller PRs myself, or I can make branches on a forked
repository, merge PRs into master on the fork along with making PRs from my
forked branch to the original master branch.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#171 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAg0TuS00YN963a96lVDA4S_vsbVQqJGks5suDR4gaJpZM4QABrt>
.
|
Fixes #114 and #162
This change is