IP scanning feature added. #23
Conversation
Updated Contributors section
There was a problem hiding this comment.
Great work @Kashish121!
Added few comments, please have a look into this.
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "python.pythonPath": "C:\\Users\\kashi\\.windows-build-tools\\python27\\python.exe" | |||
There was a problem hiding this comment.
Ignore .vscode configurations.
@Kashish121 Add .vscode to .gitignore.
There was a problem hiding this comment.
@Kashish121 Delete settings.json. The local settings shouldn't be pushed to the GitHub.
config.json
Outdated
| @@ -3,10 +3,12 @@ | |||
| "low": "1", | |||
| "high": "8888" | |||
| }, | |||
|
|
|||
| "iprange": { | |||
There was a problem hiding this comment.
@Kashish121 - ipRange - follow the camel case for this file.
There was a problem hiding this comment.
Can you please clarify 'IPRange' or 'IpRange'?
There was a problem hiding this comment.
IPRange ❌
IpRange ❌
ipRange ✔️
src/ipscanner.py
Outdated
| for ip in xrange(range_low, range_high): | ||
| addr = net3+str(ip) | ||
| if (scan(addr)): | ||
| print addr + " this address is live\n" |
There was a problem hiding this comment.
So this will read like - 192.0.0.1 this address is live
@Kashish121 It should better be 192.0.0.1 is live
|
@ishika1727 Please pull @Kashish121's branch and test the functionality locally. |
|
@Kashish121 ipscanner.py prints the same IP address more than one time. Please resolve the issue.
|
src/ipscanner.py
Outdated
| # Calculates the difference of time, to see how long it took to run the script | ||
| total = td2-td1 | ||
| # Printing the information to screen | ||
| print "scanning completed in ", total |
There was a problem hiding this comment.
@Kashish121 Capitalize the first letter.
.vscode/settings.json
Outdated
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "python.pythonPath": "C:\\Users\\kashi\\.windows-build-tools\\python27\\python.exe" | |||
There was a problem hiding this comment.
@Kashish121 Delete settings.json. The local settings shouldn't be pushed to the GitHub.
There was a problem hiding this comment.
@Kashish121 Great job! 👏
✅ from my end. I'll figure out a better way to test this. Allow me sometime.
@ishika1727 Try running once again, hopefully everything should work as expected.
PS: Will merge after @ishika1727 approves!
|
@Kashish121 Make your PR ready to |
src/ipscanner.pyfeature added.config.json.src/multi/scanner_thread.py.Getting a small issue due to multithreading. Please review.