Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Web-Based Water Monitoring System.pdf #11

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Created Web-Based Water Monitoring System.pdf #11

merged 2 commits into from
Feb 18, 2020

Conversation

himanshusharma89
Copy link

@himanshusharma89 himanshusharma89 commented Jan 22, 2020

Description

I have created a document of the web-based water monitoring system.

Fixes #3

Type of change

  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My code follows the style guidelines of this project
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@vinitshahdeo vinitshahdeo self-requested a review January 22, 2020 17:17
@vinitshahdeo vinitshahdeo added the documentation Project Report label Jan 22, 2020
@vinitshahdeo
Copy link
Owner

@himanshusharma89 Thanks for the pull request. I'll go through the doc and get back to you soon.

@vinitshahdeo
Copy link
Owner

vinitshahdeo commented Jan 29, 2020

@himanshusharma89 Hey can you please add an architecture diagram how does actually this system will work?

Please check this: https://www.youtube.com/watch?v=HMa2lLVryVs

YouTube
Learn more: http://www.skyfilabs.com/online-courses/smart-water-monitoring-using-iot?v1 Smart Water Monitoring IoT Project is one of the best IoT based proje...

@himanshusharma89
Copy link
Author

I have added a diagram, please review it.

@himanshusharma89
Copy link
Author

Hello, @vinitshahdeo did you review the updates. Please revert back if the block diagram is not well built.

@vinitshahdeo
Copy link
Owner

LGTM! Will merge it soon.

@vinitshahdeo vinitshahdeo changed the base branch from master to develop February 17, 2020 20:26
@vinitshahdeo vinitshahdeo merged commit a768216 into vinitshahdeo:develop Feb 18, 2020
@welcome
Copy link

welcome bot commented Feb 18, 2020

Congrats on merging your first pull request! 🙌🎉⚡️
Show some love by starring a few of my repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Project Report JWoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project Documentation
2 participants